-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7511]Lock granularity issue causing LMQ message loss #7525
[ISSUE #7511]Lock granularity issue causing LMQ message loss #7525
Conversation
…s in topicQueueLock, should be in putMessageLock
@pingww @RongtongJin plz, have a code review |
@guyinyou plz, have a code review |
Codecov Report
@@ Coverage Diff @@
## develop #7525 +/- ##
=============================================
+ Coverage 42.98% 43.05% +0.06%
- Complexity 9674 9692 +18
=============================================
Files 1158 1159 +1
Lines 83982 84041 +59
Branches 10916 10923 +7
=============================================
+ Hits 36102 36183 +81
+ Misses 43380 43350 -30
- Partials 4500 4508 +8
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LGTM~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which Issue(s) This PR Fixes
Fixes #7511
Brief Description
topicQueueLock cannot guarantee that the offset of LMQ is set correctly, so the offset maintenance of LMQ is placed in the critical section protected by putMessageLock.
How Did You Test This Change?
How Did You Test This Change?