[ISSUE #7523] message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH #7524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
Nov 1, 2023
| // two times the flush | ||
| boolean flushOK = CommitLog.this.mappedFileQueue.getFlushedWhere() >= req.getNextOffset(); | ||
| for (int i = 0; i < 2 && !flushOK; i++) { | ||
| boolean flushOK = false; |
There was a problem hiding this comment.
How about flushOK=CommitLog.this.mappedFileQueue.getFlushedWhere() >= req.getNextOffset() when init？ Prevent every request from flushing at least once.
Codecov Report
@@ Coverage Diff @@
## develop #7524 +/- ##
=============================================
+ Coverage 42.98% 43.01% +0.02%
- Complexity 9674 9680 +6
=============================================
Files 1158 1158
Lines 83982 83987 +5
Branches 10916 10917 +1
=============================================
+ Hits 36102 36128 +26
+ Misses 43380 43366 -14
+ Partials 4500 4493 -7
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RongtongJin
approved these changes
Nov 2, 2023
joeCarf
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7523
Brief Description
1.set transientStorePoolEnable=true, flushDiskType=SYNC_FLUSH,
2.start broker
3.then send message to broker, client receives FLUSH_DISK_TIMEOUT error
By arthas, i find GroupCommitService always return FLUSH_DISK_TIMEOUT