[ISSUE #9064] Optimize transaction message callback check logic (#9062)

apache · Jan 8, 2025 · a343021 · a343021
1 parent b573df0
commit a343021
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...in/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java b/...in/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java
@@ -203,9 +203,9 @@ public void check(long transactionTimeout, int transactionCheckMax,
                         log.info("Queue={} process time reach max={}", messageQueue, MAX_PROCESS_TIME_LIMIT);
                         break;
                     }
-                    if (removeMap.containsKey(i)) {
+                    Long removedOpOffset;
+                    if ((removedOpOffset = removeMap.remove(i)) != null) {
                         log.debug("Half offset {} has been committed/rolled back", i);
-                        Long removedOpOffset = removeMap.remove(i);
                         opMsgMap.get(removedOpOffset).remove(i);
                         if (opMsgMap.get(removedOpOffset).size() == 0) {
                             opMsgMap.remove(removedOpOffset);
@@ -456,8 +456,8 @@ private boolean checkPrepareQueueOffset(HashMap<Long, Long> removeMap, List<Long
             if (-1 == prepareQueueOffset) {
                 return false;
             } else {
-                if (removeMap.containsKey(prepareQueueOffset)) {
-                    long tmpOpOffset = removeMap.remove(prepareQueueOffset);
+                Long tmpOpOffset;
+                if ((tmpOpOffset = removeMap.remove(prepareQueueOffset)) != null) {
                     doneOpOffset.add(tmpOpOffset);
                     log.info("removeMap contain prepareQueueOffset. real_topic={},uniqKey={},immunityTime={},offset={}",
                             msgExt.getUserProperty(MessageConst.PROPERTY_REAL_TOPIC),