[fix][doc] Workaround Go Yaml issue go-yaml/yaml#789 in docker-compose example #24040
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
Technoboy-,
visortelle,
nodece,
dao-jun and
heesung-sn
|
/pulsarbot rerun-failure-checks |
visortelle
reviewed
Mar 1, 2025
There was a problem hiding this comment.
The changes LGTM, but the SQL worker container restarts in a loop:
# sql1
# Restarting (1) 42 seconds ago
...
sql1 |
sql1 | -- Invalid command 'sql-worker' -- Use '/pulsar/bin/pulsar help' to get a list of valid commands
sql1 |
sql1 exited with code 1
Pulsar SQL was removed a while ago: #23435
Maybe we should also remove this container in docker-compose.yml?
Also, we probably can remove the version attribute because of this warning:
WARN[0000] /home/xxxxxxxxxxxxxxxx/apache/pulsar/docker-compose/kitchen-sink/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion
visortelle
approved these changes
Mar 1, 2025
nodece
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24039
Motivation
docker-compose examples don't work due to go-yaml/yaml#789 issue.
It's necessary to replace
command: >withcommand: |. More details in #24039 comments.Similar change was made to website docs in apache/pulsar-site@0df29a62.
Modifications
command: >withcommand: |in the docker-compose exampleDocumentation
docdoc-requireddoc-not-neededdoc-complete