Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][misc] Add override annotation #24033

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

3pacccccc
Copy link
Contributor

Modifications

add override annotation and fix typo

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: 3pacccccc#1

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (bbc6224) to head (ff3d176).
Report is 943 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24033      +/-   ##
============================================
+ Coverage     73.57%   74.21%   +0.63%     
+ Complexity    32624    32008     -616     
============================================
  Files          1877     1861      -16     
  Lines        139502   144170    +4668     
  Branches      15299    16420    +1121     
============================================
+ Hits         102638   106991    +4353     
+ Misses        28908    28731     -177     
- Partials       7956     8448     +492     
Flag Coverage Δ
inttests 26.68% <ø> (+2.09%) ⬆️
systests 23.13% <ø> (-1.20%) ⬇️
unittests 73.72% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ker/loadbalance/extensions/BrokerRegistryImpl.java 81.95% <ø> (-2.81%) ⬇️
...rg/apache/pulsar/broker/service/BrokerService.java 84.34% <ø> (+3.56%) ⬆️

... and 1057 files with indirect coverage changes

@nodece nodece merged commit 6fc9b79 into apache:master Feb 28, 2025
54 checks passed
@nodece nodece added this to the 4.1.0 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants