[improve] [broker] Separate offload read and write thread pool #24025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
horizonzy,
zymap,
poorbarcode and
codelipenghui
hangc0276
added
type/enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24025 +/- ##
============================================
+ Coverage 73.57% 74.19% +0.62%
+ Complexity 32624 32381 -243
============================================
Files 1877 1861 -16
Lines 139502 144170 +4668
Branches 15299 16420 +1121
============================================
+ Hits 102638 106970 +4332
+ Misses 28908 28761 -147
- Partials 7956 8439 +483
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zymap
approved these changes
Feb 26, 2025
Technoboy-
approved these changes
Feb 26, 2025
Technoboy-
pushed a commit
that referenced
this pull request
Feb 26, 2025
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Feb 26, 2025
… LTS - Remove `managedLedgerOffloadReadThreads` from apache#24025 - Remove `managedLedgerMaxReadsInFlightPermitsAcquireTimeoutMillis` and `managedLedgerMaxReadsInFlightPermitsAcquireQueueSize` from apache#23901 - Remove `managedLedgerCursorResetLedgerCloseTimestampMaxClockSkewMillis` from apache#22792 The configs above only increase the complexity and are hard to configure. Add more comments to `managedLedgerPersistIndividualAckAsLongArray` from apache#23759. This config was added to keep the compatibility from 3.x or earlier so it has value to retain. 3.x users must configure it with false when upgrading to 4.0.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
When we enable Jcloud offloader for all the topics, some topics need to perform catch-up read from the tiered storage; the ledger offload process and ledger catch-up read process are impacted each other due to the ledger offload and offloaded ledger read sharing the same thread pool. We need to separate the read and write thread pool for the offloader.
Modifications
Separate the read and write thread pool for the offloader.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: