Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] fix doc related to chunk message feature. #24023

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Feb 25, 2025

Motivation

Chunk message can work with shared subscription since #16202.
Related discussion refer to #24015

Modifications

Remove the incorrect doc of chunk message.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 25, 2025
@dao-jun dao-jun added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test labels Feb 26, 2025
@dao-jun dao-jun closed this Feb 26, 2025
@dao-jun dao-jun reopened this Feb 26, 2025
@github-actions github-actions bot removed the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Feb 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (bbc6224) to head (a1aca4d).
Report is 939 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24023      +/-   ##
============================================
+ Coverage     73.57%   73.92%   +0.35%     
+ Complexity    32624    32540      -84     
============================================
  Files          1877     1862      -15     
  Lines        139502   147451    +7949     
  Branches      15299    17173    +1874     
============================================
+ Hits         102638   109004    +6366     
- Misses        28908    29863     +955     
- Partials       7956     8584     +628     
Flag Coverage Δ
inttests 26.84% <ø> (+2.26%) ⬆️
systests 23.11% <ø> (-1.21%) ⬇️
unittests 73.46% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1059 files with indirect coverage changes

@thetumbled thetumbled merged commit efcf7c2 into apache:master Feb 26, 2025
75 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants