Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][pip] PIP-409: support producer configuration for retry/dead letter topic producer #24022

Merged
merged 5 commits into from
Feb 28, 2025
Merged

[improve][pip] PIP-409: support producer configuration for retry/dead letter topic producer #24022

merged 5 commits into from
Feb 28, 2025

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Feb 25, 2025 •
edited
Loading

PIP documentation.
Implementation PR: #24020

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@apache apache deleted a comment from github-actions bot Feb 25, 2025
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Feb 25, 2025
@thetumbled thetumbled mentioned this pull request Feb 25, 2025
Open
15 tasks
nodece
nodece reviewed Feb 26, 2025
View reviewed changes
nodece
nodece approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Technoboy- Technoboy- added this to the 4.1.0 milestone Feb 28, 2025
@Technoboy- Technoboy- merged commit 5973cbc into apache:master Feb 28, 2025
20 checks passed
@Technoboy-
Copy link
Contributor

Please remember to send a vote closed email for the vote thread

@thetumbled
Copy link
Member Author

Please remember to send a vote closed email for the vote thread

Got it. I plan to send the vote closed email next week to fulfill the requirement of vote exposurement.

@lhotari
Copy link
Member

lhotari commented Feb 28, 2025

Please remember to send a vote closed email for the vote thread

Got it. I plan to send the vote closed email next week to fulfill the requirement of vote exposurement.

@thetumbled Thanks for the driving the PIP. I missed the voting period and sent feedback (that should have happened during the discussion) on the voting thread: https://lists.apache.org/thread/g11mz7oxpvgjq61og23prqrg5vdkkk5s . I added the details in the PIP implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@nodece nodece nodece approved these changes

@dao-jun dao-jun dao-jun approved these changes

@shibd shibd shibd approved these changes

Assignees

@thetumbled thetumbled

Labels
doc-not-needed Your PR changes do not impact docs PIP
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
8 participants
@thetumbled @Technoboy- @lhotari @codelipenghui @nodece @BewareMyPower @dao-jun @shibd