[fix][test]Fix flaky test V1_ProducerConsumerTest.testConcurrentConsumerReceiveWhileReconnect #24019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merReceiveWhileReconnect
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24019 +/- ##
============================================
+ Coverage 73.57% 74.21% +0.63%
+ Complexity 32624 32348 -276
============================================
Files 1877 1856 -21
Lines 139502 144143 +4641
Branches 15299 16413 +1114
============================================
+ Hits 102638 106970 +4332
+ Misses 28908 28760 -148
- Partials 7956 8413 +457
Flags with carried forward coverage won't be shown. Click here to find out more. |
merlimat
approved these changes
Feb 25, 2025
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 27, 2025
…merReceiveWhileReconnect (apache#24019) (cherry picked from commit 2c686d0) (cherry picked from commit cd8640b)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 27, 2025
…merReceiveWhileReconnect (apache#24019) (cherry picked from commit 2c686d0) (cherry picked from commit c8d8b6f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2025
…merReceiveWhileReconnect (apache#24019) (cherry picked from commit 2c686d0) (cherry picked from commit cd8640b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2025
…merReceiveWhileReconnect (apache#24019) (cherry picked from commit 2c686d0) (cherry picked from commit c8d8b6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Root cause: when the verification starts, maybe there is in-flight messages dispatching
Modifications
Instead of verifying directly, use a
Awaitility.await().untilAsserted(...)Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x