[fix][broker] Add expire check for replicator

[nodece]

Motivation

#21865 removes the expire check for the replicator and compaction subscription. However, this introduces a breaking change in that the replication message never expires.

The TTL policy should be applied to the subscription and replicator.

Modifications

• Add expire check for the replicator.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[lhotari]

LGTM, just wondering whether we need more comments in the testReplicatorWithTTL test case so that it's clear what the expected behavior is. It's currently hard to validate the test case itself.

[lhotari]

LGTM, thanks for improving the test case too

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

Project coverage is 74.23%. Comparing base (bbc6224) to head (c58deee).
Report is 943 commits behind head on master.

Files with missing lines	Patch %	Lines
...ar/broker/service/persistent/ShadowReplicator.java	0.00%	8 Missing and 1 partial ⚠️
...er/service/persistent/GeoPersistentReplicator.java	66.66%	2 Missing and 1 partial ⚠️
...sar/broker/service/persistent/PersistentTopic.java	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23975      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.65%     
+ Complexity    32624    32401     -223     
============================================
  Files          1877     1861      -16     
  Lines        139502   144192    +4690     
  Branches      15299    16424    +1125     
============================================
+ Hits         102638   107037    +4399     
+ Misses        28908    28711     -197     
- Partials       7956     8444     +488     

Flag	Coverage Δ
inttests	26.65% <0.00%> (+2.07%)	⬆️
systests	23.12% <0.00%> (-1.20%)	⬇️
unittests	73.73% <40.90%> (+0.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java	79.67% <75.00%> (+1.21%)	⬆️
...er/service/persistent/GeoPersistentReplicator.java	75.40% <66.66%> (-2.62%)	⬇️
...ar/broker/service/persistent/ShadowReplicator.java	51.85% <0.00%> (-6.69%)	⬇️

... and 1053 files with indirect coverage changes