Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ml] Use lock-free queue in InflightReadsLimiter since there's no concurrent access #23962

Merged
merged 5 commits into from
Feb 25, 2025
Merged

[improve][ml] Use lock-free queue in InflightReadsLimiter since there's no concurrent access #23962

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c62bdc
Use lock-free queues in InflightReadsLimiter.java to improve performance
guan46 Feb 11, 2025
39e0bd2
Use lock-free queues in InflightReadsLimiter.java to improve performance
guan46 Feb 15, 2025
19c4331
Use lock-free queues in InflightReadsLimiter.java to improve performance
guan46 Feb 15, 2025
3aa8046
Use lock-free queues in InflightReadsLimiter.java to improve performance
guan46 Feb 15, 2025
f933447
Use lock-free queues in InflightReadsLimiter.java to improve performance
guan46 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ...d-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/InflightReadsLimiter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import io.opentelemetry.api.OpenTelemetry;
import io.opentelemetry.api.metrics.ObservableLongCounter;
import io.prometheus.client.Gauge;
import java.util.ArrayDeque;
import java.util.Optional;
import java.util.Queue;
import java.util.concurrent.ScheduledExecutorService;
Expand All @@ -31,7 +32,6 @@
import org.apache.pulsar.opentelemetry.Constants;
import org.apache.pulsar.opentelemetry.OpenTelemetryAttributes.InflightReadLimiterUtilization;
import org.apache.pulsar.opentelemetry.annotations.PulsarDeprecatedMetric;
import org.jctools.queues.SpscArrayQueue;

@Slf4j
public class InflightReadsLimiter implements AutoCloseable {
Expand All @@ -51,6 +51,7 @@ public class InflightReadsLimiter implements AutoCloseable {
public static final String INFLIGHT_READS_LIMITER_USAGE_METRIC_NAME =
"pulsar.broker.managed_ledger.inflight.read.usage";
private final ObservableLongCounter inflightReadsUsageCounter;
private final int maxReadsInFlightAcquireQueueSize;

@PulsarDeprecatedMetric(newMetricName = INFLIGHT_READS_LIMITER_USAGE_METRIC_NAME)
@Deprecated
Expand Down Expand Up @@ -82,9 +83,10 @@ public InflightReadsLimiter(long maxReadsInFlightSize, int maxReadsInFlightAcqui
this.remainingBytes = maxReadsInFlightSize;
this.acquireTimeoutMillis = acquireTimeoutMillis;
this.timeOutExecutor = timeOutExecutor;
this.maxReadsInFlightAcquireQueueSize = maxReadsInFlightAcquireQueueSize;
if (maxReadsInFlightSize > 0) {
enabled = true;
this.queuedHandles = new SpscArrayQueue<>(maxReadsInFlightAcquireQueueSize);
this.queuedHandles = new ArrayDeque<>();
} else {
enabled = false;
this.queuedHandles = null;
Expand Down Expand Up @@ -174,13 +176,14 @@ private synchronized Optional<Handle> internalAcquire(long permits, Consumer<Han
updateMetrics();
return Optional.of(new Handle(maxReadsInFlightSize, handle.creationTime, true));
} else {
if (queuedHandles.offer(new QueuedHandle(handle, callback))) {
scheduleTimeOutCheck(acquireTimeoutMillis);
return Optional.empty();
} else {
if (queuedHandles.size() >= maxReadsInFlightAcquireQueueSize) {
log.warn("Failed to queue handle for acquiring permits: {}, creationTime: {}, remainingBytes:{}",
permits, handle.creationTime, remainingBytes);
return Optional.of(new Handle(0, handle.creationTime, false));
} else {
queuedHandles.offer(new QueuedHandle(handle, callback));
scheduleTimeOutCheck(acquireTimeoutMillis);
return Optional.empty();
}
}
}
Expand Down
Loading