Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] PIP-406: Introduce metrics related to dispatch_throttled_count #23946

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[improve][broker] PIP-406: Introduce metrics related to dispatch_throttled_count #23946

wants to merge 2 commits into from

Conversation

shibd
Copy link
Member

@shibd shibd commented Feb 7, 2025 •
edited
Loading

Motivation

Refer to #23945

Modifications

  1. Maintain dispatchThrottleMsgCount and dispatchThrottleBytesCount in DispatchRateLimiter:
  2. Output these fields when retrieving topic stats and metrics.

Verifying this change

  • Add testSubscriptionStatsDispatchThrottled to cover it

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@shibd shibd added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/metrics ready-to-test labels Feb 7, 2025
@shibd shibd self-assigned this Feb 7, 2025
@shibd shibd mentioned this pull request Feb 7, 2025
Open
4 tasks
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Feb 7, 2025
@shibd shibd force-pushed the add_throttle_count branch from 13a97c0 to a51bb86 Compare February 18, 2025 09:05
@shibd shibd changed the title [improve][broker] PIP-406: Introduce pulsar_subscription_dispatch_throttled_msgs and bytes metrics [improve][broker] PIP-406: Introduce metrics related to dispatch_throttled_count Feb 18, 2025
@shibd shibd force-pushed the add_throttle_count branch from a51bb86 to 4b4915b Compare February 28, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@RobertIndie RobertIndie Awaiting requested review from RobertIndie

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@coderzc coderzc Awaiting requested review from coderzc

At least 1 approving review is required to merge this pull request.

Assignees

@shibd shibd

Labels
area/metrics doc-required Your PR changes impact docs and you will update later. ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shibd