-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][misc] Disable OTel by default when running the pulsar-perf tool #23585
[improve][misc] Disable OTel by default when running the pulsar-perf tool #23585
Conversation
An alternative would be to have OTel configured, but disabled by default as it's done in Pulsar's OpenTelemetryService: pulsar/pulsar-opentelemetry/src/main/java/org/apache/pulsar/opentelemetry/OpenTelemetryService.java Lines 74 to 75 in dd1b579
@dragosvictor Please review this PR and suggest a suitable approach. |
166ce03
to
55b8b36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23585 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.66%
+ Complexity 32624 3353 -29271
============================================
Files 1877 1945 +68
Lines 139502 149262 +9760
Branches 15299 16698 +1399
============================================
+ Hits 102638 110809 +8171
- Misses 28908 29876 +968
- Partials 7956 8577 +621
Flags with carried forward coverage won't be shown. Click here to find out more. |
Workaround for 4.0.0
|
Fixes #23475
Motivation
Since pulsar 3.3.0 (#22179), pulsar-perf constantly print warning message on the console if user haven't configured a OTel-compatible metric collector in their environment. To align with broker, proxy, and other components, OTel metric collection should be disabled in pulsar-perf by default. #22010
With this patch, the following log will appear before running the performance test:
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: