chores: remove useless code in BinaryProtoLookupService
#15350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undant `object's toString` method in outputting log or redundant data type in angle brackets on using generic type
yws-tracy
changed the title
BinaryProtoLookupService such as red…BinaryProtoLookupService
|
@yws-tracy:Thanks for your contribution. For this PR, do we need to update docs? |
|
@yws-tracy:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
merlimat
approved these changes
Apr 28, 2022
merlimat
added
the
type/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
remove useless code in
BinaryProtoLookupServicesuch as redundantobject's toStringmethod in outputting log or redundant data type in angle brackets on using generic typeModifications
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)