Revert "Refactor RealmContext to RealmId (#741)" #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit febe4e8.
flyrain
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode and
ebyhr
as code owners
There was a problem hiding this comment.
I think a lot of the changes to this file are not needed; they look unrelated to the refactor/revert
There was a problem hiding this comment.
Good catch! Reverted.
collado-mike
approved these changes
Jan 31, 2025
|
Thanks @eric-maynard and @collado-mike for the review. |
|
Hey guys. I'm a bit confused here: is it related to |
As we discussed in the sync-up, it's related to |
mlsstart
pushed a commit
to mlsstart/polaris
that referenced
this pull request
Feb 8, 2025
* Revert "Copy RealmId when passing it to TaskExecutorImpl (apache#879)" This reverts commit febe4e8. * Revert apache#741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the #741 per recent discussion.