add license details for proto file #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
requested review from
jrudolph,
raboof,
gmethvin,
nvollmar and
mdedetrich
|
I checked the PR history in akka-grpc and I'm not convinced this file is used. I'm trying a build with the file removed - see #163 |
|
closed in favour of #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure but the file we inherited from akka-grpc looks very similar to a file I found on the web and it was checked in in February 2020 - a month before the Akka file.
https://github.com/cloudstateio/dotnet-support/blob/master/examples/Crdt.Example/proto_files/example/crdts/crdt-example.proto
https://github.com/akka/akka-grpc/commits/main/interop-tests/src/main/protobuf/crdt-example.proto
There is no source header on either file and the LICENSE file in the https://github.com/cloudstateio/dotnet-support/ project is a standard Apache v2.0 license with no specific copyright in it.
https://github.com/cloudstateio/dotnet-support/