use env variables for AWS creds

apache · Sep 26, 2024 · 91b17fe · 91b17fe
1 parent e3c3f47
commit 91b17fe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/check-build-test.yml b/.github/workflows/check-build-test.yml
@@ -1,7 +1,6 @@
 name: CI
 
 on:
-  pull_request:
   push:
     branches:
       - main

diff --git a/.github/workflows/nightly-builds.yaml b/.github/workflows/nightly-builds.yaml
@@ -4,6 +4,7 @@ on:
   schedule:
     - cron: "0 3 * * *"
   workflow_dispatch:
+  pull_request:
 
 permissions: {}
 
@@ -56,12 +57,14 @@ jobs:
       - name: Cache Coursier cache
         uses: coursier/cache-action@v6
 
-      - name: S3 Integration tests
+      - name: AWS Connectors Integration tests
+        env:
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_KEY }}
         run:  |-
           sbt \
-          -Dpekko.connectors.s3.aws.credentials.provider=static \
-          -Dpekko.connectors.s3.aws.credentials.access-key-id=${{ secrets.AWS_ACCESS_KEY }} \
-          -Dpekko.connectors.s3.aws.credentials.secret-access-key=${{ secrets.AWS_SECRET_KEY }} \
           -Dpekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec.enableListAllMyBucketsTests=false \
           -Dpekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec.enableMFATests=false \
           + "s3/Test/runMain org.scalatest.tools.Runner -o -s org.apache.pekko.stream.connectors.s3.scaladsl.AWSS3IntegrationSpec"
+          sbt \
+          + "aws-spi-pekko-http/it:test"