-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates repo diagram to reflect current components #4873
base: master
Are you sure you want to change the base?
Conversation
We have tooling that generates https://github.com/apache/openwhisk/blob/master/docs/dev/modules.md Should we be leveraging that here instead of having a manual list? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Morgan, so happy to have an update that reflects that the current state of project repos. and components.
Here are a few things I was wondering if we could swizzle around...
- Is there a way graphically to carryover the concepts in markdown that feature the repos. and show the directory/components of the repos. nested/under the repo. names?
- e.g., openwhisk (column) should have openwhisk directories under, but runtimes have repos. which represent diff. granularities...
- i.e., we should IMO the rows under each column should show top-level (hyperlinked) repos. and perhaps unordered bulleted list for significant subdirs/areaas
- Can we hyperlink to the repos.; this feature would be a great "launch point" since the main OW repo. is where 99.999% of people coming to the project start at (README).
- can we co-locate
- openwhisk with API Gateway as I see them as integral parts of the "Paltform" (maybe call the column "Platform components"?
- co-locate "catalog" with top-level "openwhisk-package-X" repos. under column "packages" where the catalog is denoted as "whisk.system" package components.
@mrutkows -- The first line of this paragraph is a link to the generated dev/modules.md file. The module list is fairly well organized, has the hyperlinks. Why duplicate? |
@dgrove-oss mostly for 2 reasons
Perhaps automation (despite markdown not supporting imports) would be possible, but a short term correction may be in order. we can link to that document, but perhaps seek to avoid duplication. |
@dgrove-oss so what do want done with the green diagram which is incorrect? |
@dgrove-oss if you think the best solution is a static image, I can just create a new image with the correct components listed. Further, I could do some image mapping using HTML to create a link to each component from within the image. Just let me know what option you would prefer. |
Hi Morgan, its great you are putting the time into updating this. I'm fine with either a markdown table or an image. I agree with you that a markdown table will probably be easier to maintain. You might be able to seed that markdown table by grabbing the rows for the "active" projects from the modules.md file, copying them into the main readme, and adjusting. I was initially hoping to be able to generate this new table using the same machinery we are using to generate modules.md, but since markdown doesn't support including files its probably not worth the effort. Module structure doesn't change that rapidly. |
Description
Fixes issue #3553: This change converts the repo diagram to two tables instead of a static image. It updates the components to reflect components that are active today. After discussion with @mrutkows, we decided to use a markdown table instead of an image to promote maintainability.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: