arch/esp32_spi: Add check to see if the TX_FIFO is empty #15904
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid sending empty data Signed-off-by: nuttxs <[email protected]>
github-actions
bot
added
Arch: xtensa
|
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although the Testing section could be improved. While it specifies the target, it lacks specific build host information (OS, compiler, etc.) and, critically, it's missing the actual content of the testing logs before and after the change. Simply stating "ESP32 as SPI master device send data" isn't sufficient evidence of testing. The logs should demonstrate the erroneous behavior before the fix and the correct behavior afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
arch/esp32_spi: Add check to see if the TX_FIFO is empty to avoid sending empty data
Impact
New Feature/Change: Issue fix (no new feature).
User Impact: No
Build Impact:No new Kconfig options or build system changes.
Hardware Impact: Only ESP32; other architectures unaffected.
Security: No
Compatibility: Backward-compatible; no breaking changes.
Testing
ESP32-DevKitC, NuttX with SPI configurations, ESP32 as SPI master device send data.