-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/arm/tiva: Add complementary PWM mode support #15872
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although it is missing some key information in the Testing section. While the summary and impact sections are well-written and address all the necessary points, the testing section needs improvement. Specifically, it lacks "Testing logs before change" and "Testing logs after change." These logs are crucial for demonstrating the actual impact of the changes and verifying the functionality. Simply stating the target and build environment is insufficient. The logs should show the PWM output before and after enabling the complementary mode to prove the change is working as intended. Include relevant output from a logic analyzer or oscilloscope demonstrating the complementary PWM signals. Provide concrete examples of the tests performed and their corresponding output. For example:
By adding these testing logs, the PR will fully comply with the NuttX requirements and provide reviewers with the necessary evidence to evaluate the changes effectively. |
Nice contribution! Apart from those two comments, don't you have to setup GPIO for low PWM output as well? It seems the call for high output GPIO is in |
@sydeney nice work! TIVA arch deserves more care, remember the pandemic when all STM32 are gone. It is good to have alternatives! |
7974674
to
ac60544
Compare
I agree. My goal is to make TIVA arch as complete as possible to power electronics projects. |
1fe71c5
to
ba8a05b
Compare
This commit improves the configuration of complementary PWM mode for Tiva C-Series microcontrollers by moving the complementary flag definition directly into each channel structure. Changes made: - Renamed 'complementary_generation' to 'complementary' for clarity. - Moved complementary mode configuration into the static PWM channel structures. - Replaced runtime conditional checks with compile-time configuration using '#ifdef CONFIG_TIVA_PWM_COMPLEMENTARY_Gx'. - Improved readability and maintainability of the PWM driver. These modifications ensure a more efficient initialization process, reduce runtime conditionals, and align better with NuttX coding practices. Signed-off-by: Sydeney Araujo <[email protected]>
ba8a05b
to
8c1dde4
Compare
This commit introduces support for complementary PWM mode on the Tiva C-Series microcontrollers. The feature allows configuring specific PWM generators to operate in complementary mode via Kconfig.
Summary
This change adds support for complementary PWM mode on Tiva C-Series microcontrollers in NuttX.
The feature allows configuring individual PWM generators to operate in complementary mode via Kconfig options.
The implementation preserves backward compatibility, ensuring that the default behavior remains unchanged.
The complementary mode can be enabled for each generator separately using:
The changes are contained within:
Impact
This change:
Testing
The implementation was tested on:
Configuration: Custom defconfig with:
Before change
After change