-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include/stdlib.h: define system()'s prototype for the flat build #15756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$(APPDIR)` folder is added to the `$(KERNDEPDIRS)` when `CONFIG_BUILD_KERNEL=y`. The `depend` phase iterates over the `$(KERNDEPDIRS)` folders and executes the `depend` recipe of these folders (including the apps' recipes) with the `__KERNEL__` macro defined, which prevents `system()`'s prototype from being declared.
anchao
approved these changes
Feb 5, 2025
jerpelea
approved these changes
Feb 5, 2025
acassis
approved these changes
Feb 5, 2025
@nuttxpr test milkv_duos:nsh |
[Experimental Bot, please feedback here] Build and Test Successful (milkv_duos:nsh)
|
lupyuen
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK on real hardware: Oz64 SG2000 RISC-V SBC. Thanks :-)
anchao
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
$(APPDIR)
folder is added to the$(KERNDEPDIRS)
whenCONFIG_BUILD_KERNEL=y
. Thedepend
phase iterates over the$(KERNDEPDIRS)
folders and executes thedepend
recipe of these folders (including the apps' recipes) with the__KERNEL__
macro defined, which preventssystem()
's prototype from being declared.Impact
Impact architectures that build App's dependencies (the
depend
recipe) withCONFIG_SYSTEM_SYSTEM=y
. This is the case, for instance, when building Python's library with support to thesystem()
function.This PR closes #15721
Testing
Internal CI testing +
rv-virt:python
withsystem()
support:Before this PR, it failed with: