fix compile error #15681
Closed
fix compile error #15681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC: socket/listen.c chip/lpc17_40_i2c.c: In function 'lpc17_40_i2cbus_initialize':
chip/lpc17_40_i2c.c:534:29: warning: 'priv' is used uninitialized [-Wuninitialized]
534 | flags = spin_lock_irqsave(&priv->spinlock);
| ^~~~~~~~~~~~~~~
chip/lpc17_40_i2c.c:529:29: note: 'priv' was declared here
529 | struct lpc17_40_i2cdev_s *priv;
| ^~~~
Signed-off-by: hujun5 <[email protected]>
github-actions
bot
added
Arch: arm
xiaoxiang781216
approved these changes
Jan 24, 2025
|
[Experimental Bot, please feedback here] No. The PR summary lacks crucial information. It states what the error is, but not why it occurs, how the change fixes it, or which functional part of the code is affected (i.e., I2C driver). The Impact section is too brief and doesn't address all the points. The Testing section doesn't provide any actual logs or specify the host/target environments used for testing. Simply stating "ci" isn't sufficient. A proper "before" and "after" demonstration of the fix is necessary. |
lupyuen
approved these changes
Jan 24, 2025
1 task
|
Submitting this patch alone will result in a CI error. Since there are other issues that need to be resolved, I have submitted the other issues together with this patch, and this pull request can be closed. #15683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix compile error
CC: socket/listen.c chip/lpc17_40_i2c.c: In function 'lpc17_40_i2cbus_initialize': chip/lpc17_40_i2c.c:534:29: warning: 'priv' is used uninitialized [-Wuninitialized]
534 | flags = spin_lock_irqsave(&priv->spinlock);
| ^~~~~~~~~~~~~~~
chip/lpc17_40_i2c.c:529:29: note: 'priv' was declared here
529 | struct lpc17_40_i2cdev_s *priv;
| ^~~~
Impact
none
Testing
ci