Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86_64: fix regression https://github.com/apache/nuttx/pull/15651 #15670

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

hujun260
Copy link
Contributor

Summary

x86_64: fix regression #15651

reason:
In x86_64, tcb->xcp.regs is always valid, and we obtain the location where the context is saved through irq_xcp_regs every time an interrupt occurs.

Impact

x86_64

Testing

qemu-intel64:nsh

reason:
In x86_64, tcb->xcp.regs is always valid, and we obtain the location
where the context is saved through irq_xcp_regs every time an interrupt occurs.

Signed-off-by: hujun5 <[email protected]>
@github-actions github-actions bot added Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small labels Jan 23, 2025
@nuttxpr
Copy link

nuttxpr commented Jan 23, 2025

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the basic NuttX requirements, but is lacking important details. While it identifies the problem and platform, it's missing crucial information for proper review:

  • Insufficient Summary: The summary needs to explain how the regression was fixed. What was changed in the code?
  • Missing Impact Details: While x86_64 is mentioned, it needs to specify whether this is a new feature, a bug fix (which it seems to be), and if there are any user-facing changes, build changes, documentation needs, etc. Even if the answer is "NO", explicitly stating it is important.
  • Missing Test Logs: The provided test logs are placeholders. Actual logs demonstrating the issue before the fix and the corrected behavior after the fix are essential for verifying the change. What commands were run? What was the incorrect output? What is the correct output?
  • Lack of Specificity: Phrases like "works as intended" are too vague. Be explicit about what was tested and the expected results.

In short, while the framework is there, the content needs to be significantly expanded to provide reviewers with the necessary information to properly evaluate the PR.

@xiaoxiang781216 xiaoxiang781216 merged commit aa9f366 into apache:master Jan 23, 2025
12 checks passed
@hujun260 hujun260 deleted the apache_69 branch January 24, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: x86_64 Issues related to the x86_64 architecture Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants