Because sched_lock is now called in spin_lock_irqsave, there is no ne…

[wangzhi-art]

Summary

Because sched_lock is now called in spin_lock_irqsave, there is no need to call it explicitly.
please see #14578 for more info.

Impact

All places that call the spin_lock_irqsave interface and also call sched_lock in arch directory.

Testing

CI

[nuttxpr]

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it attempts to address some points, it lacks critical details. Here's a breakdown:

• Summary: While it states why (redundant call), it's vague on what and how. Which function(s) were modified? Exactly how was the code changed (e.g., "removed the call to sched_lock within the following functions: ...")? It also lacks issue/PR references.
• Impact: The impact section is poorly formatted and lacks the required YES/NO responses. It mentions impacted code, but not the effects of the change. Will user applications need to change? Build systems? Documentation? Security considerations are completely omitted.
• Testing: CI passing is good, but insufficient. The template specifically requests logs before and after the change on a local setup, including details about that setup (host OS, target architecture, etc.). Simply saying "CI" doesn't provide enough evidence for proper review. What specific tests were run? What were the observed results demonstrating the fix?

To make this PR acceptable, it needs significant improvement in providing specific details for each section, especially regarding the impact and testing sections. Example improvements:

Summary:

This PR removes redundant calls to sched_lock within the spin_lock_irqsave function in the architecture-specific code. Since spin_lock_irqsave now implicitly calls sched_lock, explicit calls are unnecessary and potentially lead to unexpected behavior. This addresses [NuttX Issue # (if applicable)]. The change removes the explicit sched_lock call from the following functions: function1(), function2(), etc. (within arch/xxxxx/src/...).

Impact:

• Is new feature added? NO
• Is existing feature changed? YES - Removed redundant calls that could potentially cause issues.
• Impact on user (will user need to adapt to change)? NO
• Impact on build (will build process change)? NO
• Impact on hardware (will arch(s) / board(s) / driver(s) change)? YES - This change affects the arch/xxxx directory, specifically the handling of spinlocks. (List affected architectures)
• Impact on documentation (is update required / provided)? YES - The documentation for spin_lock_irqsave should be updated to reflect that it now implicitly calls sched_lock. (Indicate if the documentation update is included in this PR)
• Impact on security (any sort of implications)? NO (or YES if there are any, explain)
• Impact on compatibility (backward/forward/interoperability)? NO (or YES if there are any, explain)
• Anything else to consider? NO

Testing:

• Build Host(s): Linux (Ubuntu 20.04), x86_64, GCC 9.4.0
• Target(s): sim:qemu-x86_64, ARM:stm32f4discovery

Testing logs before change:

(Show output demonstrating the redundant calls, if possible. At minimum, show the test commands used)

Testing logs after change:

(Show output demonstrating the issue is resolved, e.g., absence of redundant calls or improved performance. At minimum, show the test commands used)