Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defconfig: Delete the redundant Kasan configuration on CI #15514

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Jan 13, 2025

Note: Please adhere to Contributing Guidelines.

Summary


arm/qemu-v7a:
            1. Keep arm/smp configuration, use kasan in generic mode
arm64/qemu-v8a:
            1. Keep arm/citest configuration, use kasan in generic mode
            2. Keep arm/swtags configuration, use kasan in software tag mode
sim:
            1. Keep sim/ostest, use asan
            2. Keep sim/ostest_oneholder, use kasan in generic mode

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: tricore Issues related to the TriCore architecture from Infineon Arch: x86 Issues related to the x86 architecture Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Area: Memory Management Memory Management issues Area: OS Components OS Components issues Board: arm Board: arm64 Board: simulator Size: M The size of the change in this PR is medium labels Jan 13, 2025
@github-actions github-actions bot added Size: S The size of the change in this PR is small and removed Area: Documentation Improvements or additions to documentation Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: tricore Issues related to the TriCore architecture from Infineon Arch: x86 Issues related to the x86 architecture Arch: x86_64 Issues related to the x86_64 architecture Arch: xtensa Issues related to the Xtensa architecture Area: Memory Management Memory Management issues Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Jan 13, 2025
@nuttxpr
Copy link

nuttxpr commented Jan 13, 2025

[Experimental Bot, please feedback here]

Does this PR meet the NuttX Requirements? Please be concise

This PR appears incomplete and does not fully meet the NuttX requirements. The summary is too brief and lacks crucial information. It mentions changes related to KASAN and ASAN but doesn't explain why these changes are necessary or how they work. There's no mention of a related issue. The impact and testing sections are completely empty.

Specifically:

  • Summary: Needs to explain the motivation for these changes (bug fix, performance improvement, new feature?). What was the problem before and how does this change address it? How does KASAN in "generic mode" differ from other modes? What is the purpose of these specific configurations for each architecture?
  • Impact: All impact sections need to be filled out, even if the answer is "NO". If there is an impact, a description is required. For example, even if user impact is NO, explicitly state "Impact on user: NO". The use of sanitizers like KASAN and ASAN could have impacts on performance, memory usage, and build time. These need to be addressed.
  • Testing: The testing section must be completed. Provide details about the build host (OS, compiler version etc.) and target platforms. "Before" and "after" logs are required to demonstrate the effect of the change. Without these logs, there's no evidence the changes work as intended. How was the functionality verified?

Therefore, this PR needs significant revision before it can be considered.

arm/qemu-v7a:
            1. Keep arm/smp configuration, use kasan in generic mode
arm64/qemu-v8a:
            1. Keep arm/citest configuration, use kasan in generic mode
            2. Keep arm/swtags configuration, use kasan in software tag mode
sim:
            1. Keep sim/ostest, use asan
	    2. Keep sim/ostest_oneholder, use kasan in generic mode

Signed-off-by: wangmingrong1 <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 22d8a50 into apache:master Jan 13, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: arm Board: arm64 Board: simulator Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants