Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use atomic operation for g_system_ticks #15414

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

hujun260
Copy link
Contributor

@hujun260 hujun260 commented Jan 3, 2025

Summary

use atomic operation for g_system_ticks

Impact

g_system_ticks

Testing

ci

@github-actions github-actions bot added Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Jan 3, 2025
@nuttxpr
Copy link

nuttxpr commented Jan 3, 2025

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it provides a summary title, it lacks crucial details. Here's a breakdown:

  • Insufficient Summary: "use atomic operation for g_system_ticks" is a title, not a summary. It doesn't explain why the change is necessary (bug fix, performance improvement?), what g_system_ticks is, how the atomic operation is implemented, or any related issues.
  • Incomplete Impact Assessment: Simply stating "g_system_ticks" doesn't explain the impact. It needs to address all the listed points (impact on the user, build, hardware, documentation, security, compatibility). For each "YES," a description is required.
  • Inadequate Testing Information: "ci" is insufficient. It needs to specify the build host details (OS, CPU, compiler), target details (architecture, board, configuration), and provide actual testing logs before and after the change to demonstrate the improvement or fix.

This PR needs significant revision to meet the requirements. It should provide comprehensive information for each section to ensure reviewers understand the context, impact, and verification of the changes.

@xiaoxiang781216 xiaoxiang781216 merged commit 4d63921 into apache:master Jan 5, 2025
27 checks passed
@hujun260 hujun260 deleted the apache_55 branch February 5, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants