Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/Rust: Add support for x86 platform #2980

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Jan 28, 2025

Summary

  • Added support for x86 and x86_64 architectures in the Rust build system
  • Updated nuttx_rust_target_triple function in cmake/nuttx_add_rust.cmake to handle x86 and x86_64 target triples
  • Updated RUST_TARGET_TRIPLE macro in tools/Rust.mk to include x86 and x86_64 target triples

Impact

  • Enables Rust crate compilation for x86 and x86_64 platforms
  • No functional changes for existing architectures (ARM, RISC-V, etc.)
  • Improves platform compatibility and expands Rust support in NuttX

Testing

GitHub CI and local build with rust on sim32/sim64

Refer to rust-lang/rust#136181

Summary:
- Added support for x86 and x86_64 architectures in the Rust build system
- Updated `nuttx_rust_target_triple` function in `cmake/nuttx_add_rust.cmake` to handle x86 and x86_64 target triples
- Updated `RUST_TARGET_TRIPLE` macro in `tools/Rust.mk` to include x86 and x86_64 target triples

Impact:
- Enables Rust crate compilation for x86 and x86_64 platforms
- No functional changes for existing architectures (ARM, RISC-V, etc.)
- Improves platform compatibility and expands Rust support in NuttX

Signed-off-by: Huang Qi <[email protected]>
@nuttxpr
Copy link

nuttxpr commented Jan 28, 2025

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the NuttX requirements, although some sections could be more detailed. Specifically:

  • Summary: Good, clearly explains the what and how. Linking a related NuttX issue would strengthen it.
  • Impact: While it mentions platform compatibility, it lacks specifics. Does this impact any existing drivers or configurations? The "No functional changes" statement needs clarification – no changes to what functionality? Explicitly stating "NO" for the other impact categories (build, hardware, documentation, security, backward/forward compatibility) would improve clarity.
  • Testing: While referencing a Rust PR provides context, it doesn't fulfill the NuttX requirement of including actual testing logs. The mention of "GitHub CI and local build" is insufficient; provide snippets of successful build logs and ideally, some functional test output demonstrating that the Rust code operates as expected on the new architectures. Specify the OS and compiler used for the local build.

While the information provided points towards a compliant PR, adding the missing details (especially the testing logs and specific impact details) will ensure it fully adheres to the NuttX guidelines.

@xiaoxiang781216 xiaoxiang781216 merged commit 2856076 into apache:master Jan 29, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants