-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: Move crypto to drivers and open_memstream to libc #2975
Conversation
f5684b4
to
5631742
Compare
[Experimental Bot, please feedback here] No, this PR description does not adequately meet the NuttX requirements. Here's why and how to fix it: Missing Information:
Example of a Better Description: ## Summary
This PR restructures the testing folder to improve organization and maintainability. The current structure is difficult to navigate and makes it hard to locate specific tests. This change groups tests by functionality, creating subfolders for unit tests, integration tests, and system tests. This will make it easier for developers to find and run relevant tests and contribute new tests in the future. This addresses discussion in https://github.com/apache/nuttx-apps/pull/2931.
## Impact
* Is new feature added? NO
* Is existing feature changed? YES - The organization of the testing folder is changed.
* Impact on user (will user need to adapt to change)? YES - Users relying on the previous folder structure for scripting or manual testing will need to update their paths.
* Impact on build (will build process change)? NO
* Impact on hardware (will arch(s) / board(s) / driver(s) change)? NO
* Impact on documentation (is update required / provided)? YES - The testing documentation needs to be updated to reflect the new folder structure. A PR to update the documentation will be submitted separately.
* Impact on security (any sort of implications)? NO
* Impact on compatibility (backward/forward/interoperability)? YES - Existing test scripts that rely on the old folder structure may break. Guidance on migration will be provided in the updated documentation.
* Anything else to consider? None.
## Testing
I confirm that changes are verified on local setup and works as intended:
* Build Host(s): Linux (Ubuntu 20.04), x86_64, GCC 9.4.0
* Target(s): sim:qemu-x86_64
Testing logs before change:
Previous structure made it difficult to find the test_example.pyfind . -name test_example.py
New structure allows easy locationfind . -name test_example.py
By providing this level of detail, reviewers can quickly understand the changes, their impact, and the verification performed, leading to a faster and smoother review process. |
5631742
to
271a900
Compare
271a900
to
fac8942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xiaoxiang781216 :-)
There is some CI error, I have restarted, go ahead when ready :-)
follow the dissusion from: apache#2931 Signed-off-by: Xiang Xiao <[email protected]>
fac8942
to
411fb9b
Compare
CI build fixed, thank you @xiaoxiang781216, merging :-) |
Summary
follow the dissusion from:
#2931
Impact
testing folder relayout
Testing
ci