Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wamr: Map armv7a/thumbv7a to armv7/thumbv7 for wamrc #2953

Merged
merged 1 commit into from
Jan 17, 2025
Merged

wamr: Map armv7a/thumbv7a to armv7/thumbv7 for wamrc #2953

merged 1 commit into from
Jan 17, 2025

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Jan 17, 2025

Summary

  • Added explicit mapping of thumbv7a architecture to thumbv7 in the WAMR toolchain definitions
  • WAMR's AOT compiler uses armv7/thumbv7 as the target architecture for all ARMv7-A processors
  • This includes Cortex-A series processors like Cortex-A9 which use the armv7a/thumbv7a ISA

Impact

  • Fixes AOT compilation for ARM Cortex-A processors using thumbv7a architecture
  • Maintains compatibility with WAMR's expected target architecture naming
  • Ensures consistent architecture targeting across all ARMv7-A processors
  • No impact on other architectures or build configurations

Testing

GitHub CI and internal CI

@no1wudi
wamr: Map armv7a/thumbv7a to armv7/thumbv7 for wamrc
c8e08bd 
Summary:
- Added explicit mapping of thumbv7a architecture to thumbv7 in the WAMR toolchain definitions
- WAMR's AOT compiler uses armv7/thumbv7 as the target architecture for all ARMv7-A processors
- This includes Cortex-A series processors like Cortex-A9 which use the armv7a/thumbv7a ISA

Impact:
- Fixes AOT compilation for ARM Cortex-A processors using thumbv7a architecture
- Maintains compatibility with WAMR's expected target architecture naming
- Ensures consistent architecture targeting across all ARMv7-A processors
- No impact on other architectures or build configurations

Signed-off-by: Huang Qi <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 6669372 into apache:master Jan 17, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@lupyuen lupyuen lupyuen approved these changes

Assignees
No one assigned
Labels
Area: Interpreters Size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no1wudi @lupyuen @xiaoxiang781216