Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/rust: Rename hello_rust to rust/baremetal #2944

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Jan 14, 2025

Summary:

  • Renamed hello_rust example to rust/baremetal to better reflect its purpose
  • Updated file headers and Makefile paths
  • Maintained all existing Kconfig options and functionality
  • Prepares for future Rust development patterns where Cargo will be the mainstream approach, with baremetal demonstrating traditional build method
  • Creates clearer structure for Rust examples as we expand Rust support

Impact:

  • No functional changes to the example itself
  • Better organization of Rust examples under examples/rust/
  • Existing configurations using this example will continue to work
  • Build system will now look for the example in the new location

Testing:

  • Confirmed Kconfig options remain unchanged
  • GitHub CI passed and local build tested

Summary:
- Renamed hello_rust example to rust/baremetal to better reflect its purpose
- Updated file headers and Makefile paths
- Maintained all existing Kconfig options and functionality
- Prepares for future Rust development patterns where Cargo will be the
mainstream approach, with baremetal demonstrating traditional build method
- Creates clearer structure for Rust examples as we expand Rust support

Impact:
- No functional changes to the example itself
- Better organization of Rust examples under examples/rust/
- Existing configurations using this example will continue to work
- Build system will now look for the example in the new location

Testing:
- Confirmed Kconfig options remain unchanged
- GitHub CI passed and local build tested

Signed-off-by: Huang Qi <[email protected]>
@nuttxpr
Copy link

nuttxpr commented Jan 14, 2025

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the NuttX requirements. The summary clearly explains the "why," "what," and "how" of the change. The impact section addresses all relevant points, noting no user-facing changes and describing the build system impact. The testing section confirms verification on local setup and mentions successful CI runs, although ideally, specific host/target details and before/after logs would be included as per the template. While the logs are missing, the rest of the information provided suggests sufficient testing.

@xiaoxiang781216 xiaoxiang781216 merged commit 14fa7d2 into apache:master Jan 14, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants