examples/usbserial: Fix style issues in host.c #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[Experimental Bot, please feedback here] Yes. While the PR lacks specific build/target info, it clearly addresses a code style concern stemming from another PR, making the context clear. The impact is explicitly limited to code style, and testing relies on GitHub CI, which is acceptable for such a change. It would be improved by adding specific build host and target information, even if just confirming that it built cleanly on the developer's local system. |
no1wudi
force-pushed
the
clean
branch
2 times, most recently
from
9adf470 to
de858f0
Compare
- Break long preprocessor conditionals across multiple lines - Add spaces around operators for better readability - Reformat long string literals to fit within line length limits - Improve consistency in spacing around parentheses and brackets Signed-off-by: Huang Qi <[email protected]>
lupyuen
approved these changes
Jan 11, 2025
cederom
approved these changes
Jan 11, 2025
xiaoxiang781216
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix code style issue found in #2939
Impact
Code style only
Testing
GitHub CI