Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: migrate to SPDX identifier #2921

Merged
merged 13 commits into from
Dec 30, 2024
Merged

Conversation

jerpelea
Copy link
Contributor

Summary

Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Impact

SBOM

Testing

CI

Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
@nuttxpr
Copy link

nuttxpr commented Dec 29, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it touches upon some aspects, it lacks crucial details.

Here's a breakdown of what's missing:

  • Summary: While the "why" is briefly addressed, the "what" and "how" are missing. Which tools? Which part of the code is changed to use SPDX identifiers? How are they integrated? Specifics are essential. Mention the related NuttX issue number if one exists.

  • Impact: Saying "SBOM" is not enough. Address all impact points explicitly with "YES" or "NO" and provide details if "YES." For example:

    • Is new feature added? YES (SBOM generation facilitated)
    • Is existing feature changed? Potentially YES (depending on what was modified). Specify which feature.
    • Impact on user? Possibly YES or NO. Justify. Will users need to do anything differently?
    • Impact on build? Likely NO, but state explicitly.
    • Impact on hardware? Almost certainly NO, but state it.
    • Impact on documentation? Likely YES. New documentation may be required to explain how to generate the SBOM.
    • Impact on security? Potentially YES or NO. Justify your answer. Does adding SPDX identifiers introduce any vulnerabilities or improve security posture?
    • Impact on compatibility? Likely NO, but state it explicitly.
  • Testing: "CI" is insufficient. List the specific build hosts and targets used for testing. Provide actual testing logs before and after the change, not just the word "CI." What tests demonstrate that the change works as intended? Show concrete output illustrating the improvement related to SBOM generation.

In short, the PR description needs significant expansion to meet the NuttX requirements. Be specific and thorough in all sections. Provide concrete examples and data.

Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
3. All advertising materials mentioning features or use of this software must
display the following acknowledgement: This product includes software
developed by the University of California, Berkeley and its contributors.

permitted by Berkley amendment
https://ipira.berkeley.edu/sites/default/files/amendment_of_4-clause_bsd_software_license.pdf

following example from NETBSD and OPENBSD
NetBSD/src@eb7c159
openbsd/src@6580fee

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Xiaomi has submitted the SGA and we can migrate the licenses to ASF

Signed-off-by: Alin Jerpelea <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 94b9c0b into apache:master Dec 30, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants