nshlib/ifconfig: Generate default IPv4 gateway with netmask #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the order of setting network mask and gateway, re-order only, no logic change. In IPv6 cases, we may set `addr6` and prefix length together to an interface, but the gateway logic may change the value in `addr6`, and result in wrong address set to the interface. The order doesn't change behavior in network stack, so we just need to make sure the value is correct. Signed-off-by: Zhe Weng <[email protected]>
xiaoxiang781216
approved these changes
Dec 6, 2023
Generate default gateway using configured netmask instead of fixed 255.255.255.0, which may be more flexible under certain situations. e.g. A subnet like 10.0.23.16/28 may not contain the .1 address. Before: ifconfig eth0 10.0.23.22 netmask 255.255.255.252 => DRaddr:10.0.23.1 ifconfig eth0 10.0.23.22 netmask 255.255.255.240 => DRaddr:10.0.23.1 ifconfig eth0 10.0.23.22 netmask 255.255.255.0 => DRaddr:10.0.23.1 ifconfig eth0 10.0.23.22 netmask 255.255.0.0 => DRaddr:10.0.23.1 ifconfig eth0 10.0.23.22 => Mask:255.255.255.0 DRaddr:10.0.23.1 After: ifconfig eth0 10.0.23.22 netmask 255.255.255.252 => DRaddr:10.0.23.21 ifconfig eth0 10.0.23.22 netmask 255.255.255.240 => DRaddr:10.0.23.17 ifconfig eth0 10.0.23.22 netmask 255.255.255.0 => DRaddr:10.0.23.1 ifconfig eth0 10.0.23.22 netmask 255.255.0.0 => DRaddr:10.0.0.1 ifconfig eth0 10.0.23.22 => Mask:255.255.255.0 DRaddr:10.0.23.1 Signed-off-by: Zhe Weng <[email protected]>
xiaoxiang781216
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Patches included:
Before:
ifconfig eth0 10.0.23.22 netmask 255.255.255.252 => DRaddr:10.0.23.1
ifconfig eth0 10.0.23.22 netmask 255.255.255.240 => DRaddr:10.0.23.1
ifconfig eth0 10.0.23.22 netmask 255.255.255.0 => DRaddr:10.0.23.1
ifconfig eth0 10.0.23.22 netmask 255.255.0.0 => DRaddr:10.0.23.1
ifconfig eth0 10.0.23.22 => Mask:255.255.255.0 DRaddr:10.0.23.1
After:
ifconfig eth0 10.0.23.22 netmask 255.255.255.252 => DRaddr:10.0.23.21
ifconfig eth0 10.0.23.22 netmask 255.255.255.240 => DRaddr:10.0.23.17
ifconfig eth0 10.0.23.22 netmask 255.255.255.0 => DRaddr:10.0.23.1
ifconfig eth0 10.0.23.22 netmask 255.255.0.0 => DRaddr:10.0.0.1
ifconfig eth0 10.0.23.22 => Mask:255.255.255.0 DRaddr:10.0.23.1
Impact
ifconfig command
Testing
Manually