Wasm build system improvements #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit map file like NuttX's `System.map` for more debug information. Signed-off-by: Huang Qi <[email protected]>
Before WAMR 1.3.0, eabihf in wamrc is `gnueabihf`, so without this patch call wamrc will failed with target abi was `eabihf`, we should convert the standard llvm target to wamrc required. Both `eabihf` and `gnueabihf` supported after WAMR 1.3.0. Signed-off-by: Huang Qi <[email protected]>
Try to follow current NuttX's toolchain parttern: Wasm.mk: Provide target rule for building wasm module WASI-SDK.defs: Provide compile flags for building Signed-off-by: Huang Qi <[email protected]>
Signed-off-by: Huang Qi <[email protected]>
And leave all intermediate file in apps/wasm, such as .map file, entry object etc used in wasm module build. Signed-off-by: Huang Qi <[email protected]>
xiaoxiang781216
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
System.mapfor more debug information.gnueabihf, so without this patch call wamrc will failed with target abi waseabihf, we should convert the standard llvm target to wamrc required. Botheabihfandgnueabihfsupported after WAMR 1.3.0.Impact
Makefile for wasm build system
Testing
Vela and CI