ptpd: Code quality improvements #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pkarashchenko
approved these changes
Nov 27, 2023
xiaoxiang781216
approved these changes
Nov 27, 2023
|
@PetteriAimonen please rebase to pass in the CI |
PetteriAimonen
force-pushed
the
dev_ptpd3
branch
from
d86ee4e to
694761d
Compare
xiaoxiang781216
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address code style and FAR pointer issues noted by @pkarashchenko after the merging of #2210.
Also added a comment about the limitations on simultaneous use of ptpd_status(), identified by @xiaoxiang781216 in previous code review.
Impact
No functional changes.
Testing
Compiles, didn't test on hardware as no functional changes.