Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lte/lapi: Remove the PIN feature #2184

Closed
wants to merge 1 commit into from

Conversation

SPRESENSE
Copy link
Contributor

Summary

Remove the PIN feature, because the SIM may accidentally become unusable.

Impact

Only LTE feature.

Testing

Test with Spresense LTE board.

Remove the PIN feature, because the SIM may
accidentally become unusable.
@cederom
Copy link

cederom commented Nov 9, 2023

  • It this code to be removed works well in general?
  • What will happen with SIM that requires PIN and the code gets now removed?
  • Why not add option to disable that functionality and not delete working code?

@raiden00pl
Copy link
Member

Isn't it the user's responsibility to use the API correctly? If the API is dangerous for some reason, it is better to hide it behind an Kconfig option than to remove it completely.

@hartmannathan
Copy link
Contributor

I noticed the APIs do not have docstrings. Perhaps as @cederom and @raiden00pl suggest, don't delete the APIs? Instead, consider adding a comment block before the functions, consistent with most of NuttX, with text like, "WARNING: This API is dangerous because [reason]." If the caller needs to do something specific to mitigate the problems, maybe document that here also.

@acassis
Copy link
Contributor

acassis commented Mar 4, 2024

ping @SPRESENSE

@acassis
Copy link
Contributor

acassis commented Apr 29, 2024

Closing this PR, let's keep the PIN support

@acassis acassis closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants