Skip to content

Commit

Permalink
apps: Replace CONFIG_ARCH_HAVE_VFORK with CONFIG_ARCH_HAVE_FORK
Browse files Browse the repository at this point in the history
Summary:

- Resolves an issue where `vfork_test` was not executed following
  the renaming from CONFIG_ARCH_HAVE_VFORK to CONFIG_ARCH_HAVE_FORK,
  as detailed in apache/nuttx#9755.

Impact:
- Please merge apache/nuttx#11200 before
  merging this PR.

Testing:
- Successfully tested with rv-virt:smp64, spresense:smp, and sim:smp.

Signed-off-by: Masayuki Ishikawa <[email protected]>
  • Loading branch information
masayuki2009 authored and xiaoxiang781216 committed Nov 16, 2023
1 parent 144bf0b commit 79c7962
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion interpreters/bas/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ config INTERPRETER_BAS_HAVE_FTRUNCATE
config EXAMPLES_BAS_SHELL
bool "Shell support"
default n
depends on ARCH_HAVE_VFORK && EXPERIMENTAL
depends on ARCH_HAVE_FORK && EXPERIMENTAL
select LIBC_EXECFUNCS
select SCHED_WAITPID
---help---
Expand Down
4 changes: 2 additions & 2 deletions interpreters/bas/bas_statement.c
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,7 @@ struct Value *stmt_DOcondition(struct Value *value)

struct Value *stmt_EDIT(struct Value *value)
{
#if defined(CONFIG_EXAMPLES_BAS_EDITOR) && defined(CONFIG_EXAMPLES_BAS_SHELL) && defined(CONFIG_ARCH_HAVE_VFORK)
#if defined(CONFIG_EXAMPLES_BAS_EDITOR) && defined(CONFIG_EXAMPLES_BAS_SHELL) && defined(CONFIG_ARCH_HAVE_FORK)
long int line;
struct Pc statementpc = g_pc;
int status;
Expand Down Expand Up @@ -5674,7 +5674,7 @@ struct Value *stmt_SELECTCASE(struct Value *value)

struct Value *stmt_SHELL(struct Value *value)
{
#if defined(CONFIG_EXAMPLES_BAS_SHELL) && defined(CONFIG_ARCH_HAVE_VFORK)
#if defined(CONFIG_EXAMPLES_BAS_SHELL) && defined(CONFIG_ARCH_HAVE_FORK)
pid_t pid;
int status;

Expand Down
2 changes: 1 addition & 1 deletion testing/ostest/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ if(CONFIG_TESTING_OSTEST)
endif()
endif()

if(CONFIG_ARCH_HAVE_VFORK)
if(CONFIG_ARCH_HAVE_FORK)
if(CONFIG_SCHED_WAITPID)
list(APPEND SRCS vfork.c)
endif()
Expand Down
2 changes: 1 addition & 1 deletion testing/ostest/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ CSRCS += sigev_thread.c
endif
endif

ifeq ($(CONFIG_ARCH_HAVE_VFORK),y)
ifeq ($(CONFIG_ARCH_HAVE_FORK),y)
ifeq ($(CONFIG_SCHED_WAITPID),y)
CSRCS += vfork.c
endif
Expand Down
2 changes: 1 addition & 1 deletion testing/ostest/ostest.h
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ void sched_lock_test(void);

/* vfork.c ******************************************************************/

#if defined(CONFIG_ARCH_HAVE_VFORK) && defined(CONFIG_SCHED_WAITPID)
#if defined(CONFIG_ARCH_HAVE_FORK) && defined(CONFIG_SCHED_WAITPID)
int vfork_test(void);
#endif

Expand Down
2 changes: 1 addition & 1 deletion testing/ostest/ostest_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ static int user_main(int argc, char *argv[])
check_test_memory_usage();
#endif

#if defined(CONFIG_ARCH_HAVE_VFORK) && defined(CONFIG_SCHED_WAITPID)
#if defined(CONFIG_ARCH_HAVE_FORK) && defined(CONFIG_SCHED_WAITPID)
printf("\nuser_main: vfork() test\n");
vfork_test();
#endif
Expand Down
4 changes: 2 additions & 2 deletions testing/ostest/vfork.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

#include "ostest.h"

#if defined(CONFIG_ARCH_HAVE_VFORK) && defined(CONFIG_SCHED_WAITPID)
#if defined(CONFIG_ARCH_HAVE_FORK) && defined(CONFIG_SCHED_WAITPID)

/****************************************************************************
* Private Data
Expand Down Expand Up @@ -84,4 +84,4 @@ int vfork_test(void)
return 0;
}

#endif /* CONFIG_ARCH_HAVE_VFORK && CONFIG_SCHED_WAITPID */
#endif /* CONFIG_ARCH_HAVE_FORK && CONFIG_SCHED_WAITPID */

0 comments on commit 79c7962

Please sign in to comment.