[MBUILDCACHE-99] Project checksum fails to identify moved files in certain cases #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtain cases. Input files checksum is calculated by sorting all files and using their content (but not their path) to update a checksum. This means that if a file is moved / renamed in a way that doesn't change its location in the list of sorted files, the input files checksum will not change. This change adds the file's path to the checksum.
|
Maybe you could add an IT test? Thanks |
…rtain cases. Add integration test
olamy
approved these changes
Jul 15, 2024
reda-alaoui
pushed a commit
to Cosium/maven-build-cache-extension
that referenced
this pull request
Aug 31, 2024
…rtain cases (apache#161) * [MBUILDCACHE-99] Project checksum fails to identify moved files in certain cases. Input files checksum is calculated by sorting all files and using their content (but not their path) to update a checksum. This means that if a file is moved / renamed in a way that doesn't change its location in the list of sorted files, the input files checksum will not change. This change adds the file's path to the checksum. (cherry picked from commit 6680780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input files checksum is calculated by sorting all files and using their content (but not their path) to update a checksum. This means that if a file is moved or renamed in a way that doesn't change its location in the list of sorted files, the input files checksum will not change. This change adds the file's path to the checksum.
Following this checklist to help us incorporate your
contribution quickly and easily: