Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of managing the raft cluster via the client #258

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

git-hulk
Copy link
Member

❯ _build/kvctl raft list peers

|---------|-----------------------|-----------|
| NODE ID |     NODE ADDRESS      | IS LEADER |
|---------|-----------------------|-----------|
|       1 | http://127.0.0.1:6001 | YES       |
|---------|-----------------------|-----------|

❯ _build/kvctl raft add peer 2 http://127.0.0.1:6002
Add node '2' with address 'http://127.0.0.1:6002' successfully

❯ _build/kvctl -H "http://127.0.0.1:9380" raft remove peer 2
Remove node '2' successfully

```
❯ _build/kvctl raft list peers

|---------|-----------------------|-----------|
| NODE ID |     NODE ADDRESS      | IS LEADER |
|---------|-----------------------|-----------|
|       1 | http://127.0.0.1:6001 | YES       |
|---------|-----------------------|-----------|

❯ _build/kvctl raft add peer 2 http://127.0.0.1:6002
Add node '2' with address 'http://127.0.0.1:6002' successfully

❯ _build/kvctl -H "http://127.0.0.1:9380" raft remove peer 2
Remove node '2' successfully

```
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Project coverage is 46.16%. Comparing base (6c56470) to head (1a87e70).
Report is 34 commits behind head on unstable.

Files with missing lines Patch % Lines
cmd/client/command/raft.go 0.00% 105 Missing ⚠️
cmd/client/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #258      +/-   ##
============================================
+ Coverage     43.38%   46.16%   +2.77%     
============================================
  Files            37       44       +7     
  Lines          2971     4038    +1067     
============================================
+ Hits           1289     1864     +575     
- Misses         1544     1980     +436     
- Partials        138      194      +56     
Flag Coverage Δ
unittests 46.16% <0.00%> (+2.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-hulk git-hulk merged commit ee8980d into apache:unstable Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants