Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sync/atomic instead of Uber's implementation #256

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

torwig
Copy link
Contributor

@torwig torwig commented Jan 14, 2025

Thanks to @aleksraiden for the hint.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.40%. Comparing base (6c56470) to head (dee33dd).
Report is 32 commits behind head on unstable.

Files with missing lines Patch % Lines
store/cluster.go 87.09% 3 Missing and 1 partial ⚠️
controller/controller.go 0.00% 0 Missing and 2 partials ⚠️
store/engine/raft/node.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #256      +/-   ##
============================================
+ Coverage     43.38%   47.40%   +4.01%     
============================================
  Files            37       43       +6     
  Lines          2971     3932     +961     
============================================
+ Hits           1289     1864     +575     
- Misses         1544     1874     +330     
- Partials        138      194      +56     
Flag Coverage Δ
unittests 47.40% <80.55%> (+4.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torwig torwig requested review from git-hulk and jihuayu January 14, 2025 12:14
Copy link
Member

@jihuayu jihuayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@git-hulk git-hulk merged commit 7644f77 into apache:unstable Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants