Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race when updating the raft snapshot and compact threshold #253

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Jan 7, 2025

This closes #245

@git-hulk git-hulk requested review from torwig and PragmaTwice January 7, 2025 12:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.13%. Comparing base (6c56470) to head (e24df29).
Report is 29 commits behind head on unstable.

Files with missing lines Patch % Lines
store/engine/raft/node.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #253      +/-   ##
============================================
+ Coverage     43.38%   47.13%   +3.74%     
============================================
  Files            37       43       +6     
  Lines          2971     3906     +935     
============================================
+ Hits           1289     1841     +552     
- Misses         1544     1872     +328     
- Partials        138      193      +55     
Flag Coverage Δ
unittests 47.13% <83.33%> (+3.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-hulk git-hulk merged commit dd7a8c7 into apache:unstable Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in raft test case
3 participants