Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel send the probe request in the same cluster #158

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Apr 9, 2024

Before this patch, the controller will sequence send the probe request
in the same cluster, and the following nodes will be delayed if some of them
are blocking.

I have tested the new codes and it will parallel send the probe request,
and the failover also works well:

{"level":"info","timestamp":"2024-04-09T20:59:25.690+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6666","id":"tR3AfdspqUHCzCqks4OjHQgJHpErweDqSw5Ryw2Q","role":"master","addr":"127.0.0.1:6666"}
{"level":"info","timestamp":"2024-04-09T20:59:25.700+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6667","id":"XocfSzHxyW6hHpeK9GrkCPoxdAeDMSqRLF0FErAZ","role":"slave","addr":"127.0.0.1:6667"}
{"level":"info","timestamp":"2024-04-09T20:59:30.695+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6666","id":"tR3AfdspqUHCzCqks4OjHQgJHpErweDqSw5Ryw2Q","role":"master","addr":"127.0.0.1:6666"}
{"level":"info","timestamp":"2024-04-09T20:59:30.695+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6667","id":"XocfSzHxyW6hHpeK9GrkCPoxdAeDMSqRLF0FErAZ","role":"slave","addr":"127.0.0.1:6667"}
{"level":"info","timestamp":"2024-04-09T20:59:35.690+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6667","id":"XocfSzHxyW6hHpeK9GrkCPoxdAeDMSqRLF0FErAZ","role":"slave","addr":"127.0.0.1:6667"}
{"level":"info","timestamp":"2024-04-09T20:59:35.691+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6666","id":"tR3AfdspqUHCzCqks4OjHQgJHpErweDqSw5Ryw2Q","role":"master","addr":"127.0.0.1:6666"}
{"level":"info","timestamp":"2024-04-09T20:59:40.688+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6666","id":"tR3AfdspqUHCzCqks4OjHQgJHpErweDqSw5Ryw2Q","role":"master","addr":"127.0.0.1:6666"}
{"level":"info","timestamp":"2024-04-09T20:59:40.689+0800","caller":"probe/cluster.go:127","msg":"probe the cluster node: 127.0.0.1:6667","id":"XocfSzHxyW6hHpeK9GrkCPoxdAeDMSqRLF0FErAZ","role":"slave","addr":"127.0.0.1:6667"}

@git-hulk
Copy link
Member Author

git-hulk commented Apr 9, 2024

It's error-prone to test manually while changing the failover/migration, I have added an issue to improve this.

@git-hulk git-hulk merged commit 618f338 into apache:unstable Apr 10, 2024
5 checks passed
@bbqccx
Copy link

bbqccx commented Apr 11, 2024

so strong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants