JAMES-3715 Small cleanups following Netty 4 migration #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks good for me. I've cherry-picked all commits and will push them to the #886 branch. |
|
My bad f7f0c18 should be removed from here: it is a mistake... Sorry... |
Before this parameter was ignored, we can use it to size Netty server child executor instead.
Netty 4 no longer allows setting internal threads and instead relies on event loop groups. Removing unused methods...
This is dead code since the Netty 4 migration. Remove. We now have easier to exploit metrics (JMX, HTTP endpoint, logs, ES reportings) that expose more interesting applicative level metrics.
…ExecutorThreads Computation are now conducted on the child threads of the Netty4 Server bootstraps. On Netty 3 those computations were conducted on a thread pool yet separated from the Netty 'workers' which could be seen as unnecessary context switches - Netty worker threads were merely decoding and encoding the traffic.
|
Integrated in #886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @ff-wl I'm interested by your feedback...
Playing around with the code resulting from the Netty 4 migration ( #886 ) I realized:
@ff-wl feel free to cherry-pick the commits.