JAMES-3715 Graceful shutdown for Netty servers #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code need to be reworked: the graceful shutdown process takes ~2 seconds and we don't want to wait that long in tests. Solution -> make it configurable |
|
Reminder to self: I still need to turn off graceful shutdown in mailet integration tests... |
chibenwa
added a commit
to chibenwa/james-project
that referenced
this pull request
Mar 21, 2022
See apache#898 for graceful shutdown
chibenwa
added a commit
that referenced
this pull request
Mar 22, 2022
See #898 for graceful shutdown
chibenwa
force-pushed
the
netty4-gracefull-shutdown
branch
from
ff0891a to
089fc9c
Compare
chibenwa
force-pushed
the
netty4-gracefull-shutdown
branch
from
089fc9c to
d0575f1
Compare
Waits ongoing tasks being executed on Netty servers for a few seconds before releasing underlying resources (like DB connections). Especially on top of Cassandra components, this is a good first step to minimize risks of shutdowns to cause inconsistencies. The Netty4 migration enabled us to easily write such resilient behaviour while it was not implemented for the previously existing Netty 3 code.
chibenwa
force-pushed
the
netty4-gracefull-shutdown
branch
from
d0575f1 to
5d86a5b
Compare
|
I think you'll find |
|
Alreanative PR welcomed ;-) (Likely welcoming that: chibenwa#31, please open it against the ASF repo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waits ongoing tasks being executed on Netty servers for a few seconds
before releasing underlying resources (like DB connections).
Especially on top of Cassandra components, this is a good first step
to minimize risks of shutdowns to cause inconsistencies.
The Netty4 migration enabled us to easily write such resilient
behaviour while it was not implemented for the previously existing
Netty 3 code. CF #886