JAMES-3715 Tests and fix for IMAP partial Fetch #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circumstances those broke with Netty4 and the little test suite introduced here reliably demonstrates this. Furthermore, we identified an issue regarding partial fetch when only the offset is specified. This is due to the usage of Long.MAX_VALUE to represent absence, and that causes some mis-calculations down the line.
This makes the behaviour explicit and prevents mis-calculations down the line, and solves partial fetchs with only the offset (commons-net IMAP stack is happy...)
Arsnael
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces unit tests for IMAP partial fetch. Those are not working properly after the Netty 4 migration cf [JAMES-3715] upgrade to netty 4.1.72.Final #886 (comment)
I discovered a bug where a ridicoulously high size is reproded for partial fetches with an offset and no limit (close to Long.MAX) that IMAP clients are not able to handle. This is due to the use of Long.MAX_VALUE to represent absence and causes mis-calculations down the line. Fixed with the use of Optionals...