Hotfix tcc context param #6473
Closed
Hotfix tcc context param #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: release for 2.0.0
…to set parameters into BusinessActionContext (apache#6473)
TakeActionNow2019
force-pushed
the
hotfix-tcc-context-param
branch
from
e52f6f9 to
48e7896
Compare
|
Please create a PR based on the latest code branch "2. x", as the package name of the code has been changed from io. seata to org. apache. seata |
funky-eyes
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Can you add relevant test cases to prove that this modification is correct? For example, by writing test cases for TestAction, please refer to ActionInterceptorHandlerTest
TakeActionNow2019
added a commit
to TakeActionNow2019/incubator-seata
that referenced
this pull request
Apr 10, 2024
…to set parameters into io.seata.rm.tcc.api.BusinessActionContext. A interface instead of its implementation class should be passed to io.seata.integration.tx.api.interceptor.ActionInterceptorHandler#fetchActionRequestContext to get parameters noted by "BusinessActionContextParameter". apache#6473
TakeActionNow2019
added a commit
to TakeActionNow2019/incubator-seata
that referenced
this pull request
Apr 10, 2024
…to set parameters into io.seata.rm.tcc.api.BusinessActionContext. A interface instead of its implementation class should be passed to io.seata.integration.tx.api.interceptor.ActionInterceptorHandler#fetchActionRequestContext to get parameters noted by "@BusinessActionContextParameter". apache#6473
TakeActionNow2019
added a commit
to TakeActionNow2019/incubator-seata
that referenced
this pull request
Apr 10, 2024
…to set parameters into io.seata.rm.tcc.api.BusinessActionContext. A interface instead of its implementation class should be passed to io.seata.integration.tx.api.interceptor.ActionInterceptorHandler#fetchActionRequestContext to get parameters noted by "@BusinessActionContextParameter". apache#6473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix the failure of @BusinessActionContextParamete annotation to set parameters into io.seata.rm.tcc.api.BusinessActionContext
Ⅱ. Does this pull request fix one issue?
fixes #6454
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews