Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1131] test migration from V7 to code generation-11 #3601

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Abhitocode
Copy link
Contributor

@Abhitocode Abhitocode commented Aug 1, 2024

In addition to previous changes associated,
Migrated tests within StandaloneBPMNProcessTest.java

The test can be identified by referring to StandaloneBPMNProcessTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/StandaloneBPMNProcessTest.java

Closes apache/incubator-kie-issues#1131.

Note: will resolve conflicts once reviewed for any changes.

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-11 branch from b7a3c63 to 688d5eb Compare August 2, 2024 04:49
@elguardian
Copy link
Contributor

plz rebase

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-11 branch from 688d5eb to 48314d6 Compare August 6, 2024 11:06
@Abhitocode Abhitocode marked this pull request as ready for review August 6, 2024 19:34
Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs one more a approval and be green

@elguardian elguardian requested a review from martinweiler August 8, 2024 09:21
Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Abhitocode

@elguardian elguardian merged commit 131de5c into apache:main Aug 9, 2024
8 of 11 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate process test migration from v7 legacy runtime to code generation
3 participants