[incubator-kie-issues-1131] test migration from V7 to code generation-9 #3596
Conversation
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3596 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3596/1/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.AsyncAPIIT.testConsumerjava.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details |
|
|
||
| assertThat(processInstance.status()).isEqualTo(org.jbpm.process.instance.ProcessInstance.STATE_COMPLETED); |
There was a problem hiding this comment.
This test misses a check to verify if the end signal is actually sent and contains the data.
There was a problem hiding this comment.
Will go through the test again and update
There was a problem hiding this comment.
Do I have to implement using any signal handlers but couldnt find any signal handler inherited from kogitoWorkItemHandler, is there any other solution?
There was a problem hiding this comment.
/jbpm-tests/src/test/java/org/jbpm/test/utils/ReceiveTaskTestHandler.java
/jbpm-tests/src/test/java/org/jbpm/test/utils/SendTaskTestHandler.java
Abhitocode
force-pushed
the
incubator-kie-issues-1131-9
branch
from
c590fbc to
1852bba
Compare
Abhitocode
force-pushed
the
incubator-kie-issues-1131-9
branch
from
1852bba to
d50e3dc
Compare
There was a problem hiding this comment.
My comment related to the testSignalEndWithData test still stands, but as the test did not contain such a verification to start with, I would say that's ok.
Good work @Abhitocode
In addition to previous changes associated,
Migrated tests within EndEventTest.Java
The test can be identified by referring to EndEventTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/EndEventTest.java
Closes apache/incubator-kie-issues#1131.