Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1131] test migration from V7 to code generation-8 #3593

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Abhitocode
Copy link
Contributor

@Abhitocode Abhitocode commented Jul 26, 2024

In addition to previous changes associated,
Migrated tests within CompensationTest.Java

The test can be identified by referring to CompensationTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/CompensationTest.java

Closes apache/incubator-kie-issues#1131.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Jul 26, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3593 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3593/1/display/redirect

Test results:

  • PASSED: 3279
  • FAILED: 2

Those are the test failures:

org.jbpm.bpmn2.CompensationTest.compensationInSubSubProcesses Process could not be validated ![Process 'Default Process' [InSubSubProcess]: Node 'Boundary Compensate 3' [_X-1] Event has no outgoing connection, Process 'Default Process' [InSubSubProcess]: Node 'Compensate Handler 3' [_X-2] Action has no incoming connection., Process 'Default Process' [InSubSubProcess]: Node 'Boundary Compensate 2' [_Y-1] Event has no outgoing connection, Process 'Default Process' [InSubSubProcess]: Node 'Compensate Handler 2' [_Y-2] Action has no incoming connection., Process 'Default Process' [InSubSubProcess]: Node 'Compensate Handler 3' [_X-2] Has no connection to the start node., Process 'Default Process' [InSubSubProcess]: Node 'Compensate Handler 2' [_Y-2] Has no connection to the start node.]
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3
expected: 3
but was: 2

@elguardian
Copy link
Contributor

@Abhitocode try to debug RuleFlowProcessValidator and check whether the error comes from.

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-8 branch 2 times, most recently from 970e2fd to 23d69ab Compare August 6, 2024 19:23
@Abhitocode Abhitocode marked this pull request as ready for review August 6, 2024 19:36
Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elguardian elguardian requested a review from martinweiler August 8, 2024 06:48
@elguardian
Copy link
Contributor

@Abhitocode fix CI plz.

@Abhitocode Abhitocode force-pushed the incubator-kie-issues-1131-8 branch from 23d69ab to dca884c Compare August 13, 2024 02:14
@elguardian elguardian merged commit 7041f76 into apache:main Aug 13, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate process test migration from v7 legacy runtime to code generation
4 participants