Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logback-classic version upgrade #6233

Closed
wants to merge 4,075 commits into from
Closed

Conversation

RemyaK1
Copy link

@RemyaK1 RemyaK1 commented Jan 27, 2025

Thank you for submitting this pull request

NOTE!: Double-check the target branch for this PR.
The default is main so it will target Drools 8 / Kogito.

Ports If a forward-port or a backport is needed, paste the forward port PR here

Issue: (please edit the GitHub Issues link if it exists)

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

jstastny-cz and others added 30 commits July 3, 2024 16:02
* NO_ISSUE: use release shared library

* add gpg into branch.yaml

---------

Co-authored-by: jstastny-cz <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…when duplicated (apache#6013)

* removing kie-ci from dependency, because it causes a test failure in KieBaseIncludeTest

* Use canonicalKieModule.getKiePackages() rather than getKieBase()

* null check for kiePackage

* move populateIncludedRuleNameMap out of packages loop

* removed unused FileManager

* performance improvement. Use getModelForKBase instead of getKiePackages

* Fit into build phases

* clean up
… be more user friendly (apache#6014)

* Improved Error Messages + Logs

* dependabot.yml fixed

* dependabot.yml fixed

* Change Request

* Minor change

* Tests fixed
* Increase setup-branch job timeout

* Increase setup-branch job timeout
…he to sign the artifacts (apache#6026)

* Adjust pipelines to use the gpg key provided by Apache to sign the artifacts

* Update builder image
…teMethod (apache#6023)

* [incubator-kie-issues#1370] Clean up signature/unused code

* [incubator-kie-issues#1370] WIP. Implemented first unit test

* [incubator-kie-issues#1370] WIP. Implemented unit tests

* [incubator-kie-issues#1370] WIP. Further refactoring with unit tests. Fully working

* [incubator-kie-issues#1370] WIP. Begin ScorerHelper implementation. Fully working

* [incubator-kie-issues#1370] WIP. Implemented ScorerHelper with test. Fully working

* [incubator-kie-issues#1370] WIP. TODO: fix score logic - corner cases not covered. Issues with singleton list of null element

* [incubator-kie-issues#1370] Working. Implemented tests.

* [incubator-kie-issues#1370] Fully working. Fixing corner cases with Object parameters

* [incubator-kie-issues#1370] Implemented CustomFunction invocation test

* [incubator-kie-issues#1370] Improvement based on PR suggestion

* [incubator-kie-issues#1370] Fix formatting

* [incubator-kie-issues#1370] Benchmark improving - refactoring

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
…coerce single item to a List (apache#5997)

* Fix + Tests

* Fix + Tests

* Fix + Tests

* Tests fixed

* Fix + Tests

* Fix + Tests

* Fix

* Revert

* Fix

* Fix

* Improving scoring

* BaseFEELFunction updated

* BaseFEELFunction updated

* Revert context function

* context function

* Revert some changes + Tests

* Change
… implementation (apache#6029)

* [DBACLD-143918] Write developer documentation for the DMN implementation - WIP

* [DBACLD-143918] Write developer documentation for the DMN implementation - WIP

* [DBACLD-143918] Write developer documentation for the DMN implementation - WIP

* [DBACLD-143918] Write developer documentation for the DMN implementation - WIP

* [DBACLD-143918] Write developer documentation for the DMN implementation

* [incubator-kie-issues#1395] Add puml explanation to main README.md

* [incubator-kie-issues#1395] Expand guide as per PR suggestion

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
* removed full-time from example rule name and comments

* removed full-time from example rule name and comments

* Replaced "at least" with "more than" for > tests

* Adjusted text and format of not forall note

* Revert "Adjusted text and format of not forall note"

This reverts commit 1662bfb.

* Change = to == for equality tests
…tly managed (apache#6033)

* [incubator-kie-issues#1356] Implemented TupleIdentifier as key for nods maps inside DMNModelImpl

* [incubator-kie-issues#1356] Working with tests

* [incubator-kie-issues#1356] Fix null management inside TupleIdentifier. Add  tests.

* [incubator-kie-issues#1356] Add symmetrical equality tests for TupleIdentifier

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
…a DateTime with a number (apache#6040)

* Removed the addition of temporal with number and added test cases

* removed unused import

* replaced null object with list of null
…ically-generated iteration contexts (apache#6041)

* [incubator-kie-issues#1350] Refactor ForExpressionNode to allow dynamically-generated iteration contexts

* [incubator-kie-issues#1350] Fix headers

* [incubator-kie-issues#1350] Minor fix

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
…nition (namespace#local_part) for local elements. (apache#6050)

Co-authored-by: Gabriele-Cardosi <[email protected]>
…hen available in classpath (apache#6054)

- Add drools.metric.micrometer.disabled switch
…ly fail with Request Timeout (408) (apache#6056)

- Disable parallel put
pibizza and others added 21 commits December 11, 2024 08:23
…apache#6191)

* Migrated last tests. A number of tests disabled

* Opened issue for failing test
…pache#6188)

* [incubator-kie-drools-6163] Clean up leftover of change-set support

* remove .rat-excludes entries
apache#6186)

* [incubator-kie-drools-6180] accumulate min doesn't evaluate correctly with more than 18 digits BigDecimal

* fixed assertion
…ompilation (apache#6192)

* [KIE-DROOLS-6190] fix removal of detached tuples during incremental compilation

* add missing license

* wip

* wip

* wip
…fo from license file (apache#6195)

* apache#1708 - Replace original implementation and remove copyright info from license file

* incorporating PR review feedback
…pache#6196)

* apache#1710 - library still present and requires LICENSE file update

* Update LICENSE

---------

Co-authored-by: Toshiya Kobayashi <[email protected]>
* [incubator-kie-drools-6203] Adjust docs for 10.0.0
- Remove unused adoc files
- Change kiegroup/drools to apache/incubator-kie-drools

* Add entries to release notes

* - release note: DMN 1.5
… turtle tests (apache#6207)

* Fixed profile execution of turtle tests

* Cleanup of TurtleTestsCategory

* Reactivated all Turtle tests

* Reenabled test disabled
…nt (apache#6208)

Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.4.14 to 1.5.13.
- [Commits](qos-ch/logback@v_1.4.14...v_1.5.13)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ext ClassLoader from the parent thread (apache#6211)

* kie-issue#1738: customize ForkJoinPool to explicitly inherit the context ClassLoader from the parent thread

* kie-issue#1738: ops, forgot the header :)
* [incubator-kie-issues#1659] Implemented FEELBuilder. Removing FEEL static methods. Add usage of FEELDialect inside BaseFEELTest

* [incubator-kie-issues#1187] Split EvalHelper

* [private-bamoe-issues#1659] WIP - working compilation.

* [private-bamoe-issues#1659] WIP - working compilation. Put on hold for other refactoring (incubator-kie-issues#1206)

* [private-bamoe-issues#1659] Implementing B-FEEL - overall working. Suspend to refactor functions as per incubator-kie-issues#1344

* [incubator-kie-issues#1742] Working status - compilation and tests succeed

* [incubator-kie-issues#1742] Fixed as per PR suggestion

* [incubator-kie-issues#1742] Extend test coverage

* [incubator-kie-issues#1742] WIP

* [incubator-kie-issues#1742] Fixing headers

* [incubator-kie-issues#1742] WIP

* [incubator-kie-issues#1742] Implemented BFEEL local override management

* [incubator-kie-issues#1742] Removing duplicated decision/assertions

* [incubator-kie-issues#1742] Moving/renaming/testing "equal" method to BooleanEvalHelper

* [incubator-kie-issues#1742] Extending BFEEL paradigm to all functions.
Implementing overall BFEELValueFunctionTest

* [incubator-kie-issues#1742] Fixed as per PR review

* [incubator-kie-issues#1742] Fixing license header

* [incubator-kie-issues#1742] Fixed as per PR review

* [incubator-kie-issues#1742] Fixed as per PR review

* [incubator-kie-issues#1742] Fixed as per PR review

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
…roject templates; remove outdated comment in ChainedProperties (apache#6218)
…pache#6223)

* [incubator-kie-issues-162105] Code fix to return list of dates

* [incubator-kie-issues-162105] WIP

* [incubator-kie-issues-162105] WIP

* [incubator-kie-issues#1743] Updated test cases

* [incubator-kie-issues#1743] Code refactoring

* [incubator-kie-issues#1743] Code refactoring

* [incubator-kie-issues#1743] Code clean up

* [incubator-kie-issues#1743] Updated test cases

* [incubator-kie-issues#1743] Code fixes

* [incubator-kie-issues#1743] Code clean up

* [incubator-kie-issues#1743] Fix review comments

* [incubator-kie-issues#1743] Code fix

* [incubator-kie-issues#1743] Fix review comments

* [incubator-kie-issues#1743] Fix merge conflicts

* [incubator-kie-issues#1743] Fix broken testcases and remove unused classes

---------

Co-authored-by: athira <[email protected]>
@yesamer
Copy link
Contributor

yesamer commented Jan 27, 2025

@RemyaK1 Thank you for the PR, can you please check if the same dependency should be updated in other repos? eg. kogito-runtimes

@RemyaK1
Copy link
Author

RemyaK1 commented Jan 28, 2025

@RemyaK1 Thank you for the PR, can you please check if the same dependency should be updated in other repos? eg. kogito-runtimes

Hi @yesamer I didn't find any dependency in Kogito-runtimes. The places where I found this dependency are jbpm-playground and droolsjbpm-build-bootstrap and PRs are raised for both of them kiegroup/droolsjbpm-build-bootstrap#2545, kiegroup/jbpm-playground#28

@yesamer
Copy link
Contributor

yesamer commented Jan 28, 2025

@RemyaK1 I found this reference in kogito-runtime

Screenshot 2025-01-28 at 16 29 17

@RemyaK1 RemyaK1 changed the base branch from main to 7.67.x-blue January 29, 2025 08:49
@RemyaK1
Copy link
Author

RemyaK1 commented Jan 29, 2025

The base branch needs to be 7.67.x-blue. The branch needs to be changed because it seems conflicts are there when I change it from here. Hence closing this PR and will raise a new PR

@RemyaK1 RemyaK1 closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.